This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Fix Solaris/SPARC bootstrap without gas

From: Jakub Jelinek <jakub at redhat dot com>
To: Gerald Pfeifer <gerald at pfeifer dot com>
Cc: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>, gcc-patches at gcc dot gnu dot org, David Miller <davem at davemloft dot net>
Date: Tue, 26 Jan 2010 23:47:01 +0100
Subject: Re: PATCH: Fix Solaris/SPARC bootstrap without gas
References: <yddiqao5zbr.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <alpine.LSU.1.99.1001262318350.21091@acrux.dbai.tuwien.ac.at>
Reply-to: Jakub Jelinek <jakub at redhat dot com>

On Tue, Jan 26, 2010 at 11:26:06PM +0100, Gerald Pfeifer wrote:
> On Tue, 26 Jan 2010, Rainer Orth wrote:
> > Ok for mainline?
> 
> -#if defined (OBJECT_FORMAT_ELF) && !defined (HAVE_GNU_AS)                      
> +#if defined (OBJECT_FORMAT_ELF) && !HAVE_GNU_AS    
> 
> Our own -Wundef will warn about code like this.  One way to avoid that is 
> writing it as

Why would it?  As Rainer correctly said, HAVE_GNU_AS is always defined,
either to 0 or to 1.
E.g. gcc.c uses
#if HAVE_GNU_AS
as well.

	Jakub

References:
- PATCH: Fix Solaris/SPARC bootstrap without gas
  - From: Rainer Orth
- Re: PATCH: Fix Solaris/SPARC bootstrap without gas
  - From: Gerald Pfeifer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]