This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, fortran] PR41167 - ICE with PACK() and string concatenation

Jerry DeLisle wrote:
Paul Richard Thomas wrote: 
Well, here is the proper fix :-)  The calls to pack, in the testcase,
now simplify to the correct result.  If the derived type parameter
value expression is used, as in this case, the type of the expression
will not be correct if the original expression has component
references.  This patch applies the type of the array elements to the
array, after simplification.

Bootstraps and regtests on FC9/x86_64 - OK for trunk?


This problem may be similar to what I am seeing on 41044. The derived type parameter is not getting simplified correctly for the call to index. We end up passing an expression type of EXPR_ARRAY of BT_DERIVED to the function. I was just starting to look at gfc_simplify_expr.

Paul maybe you can have a look there as well. In the meantime i will try this patch.

Jerry

I was right. Paul got a twofer. It fixes 41044!

Patch approved!

Jerry

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]