Re: Fix PR41879 (large mgrid regression)

[Michael Matz <matz at suse dot de>]

Hi,

On Sat, 16 Jan 2010, Richard Guenther wrote:

> > @@ -631,6 +644,12 @@ split_constant_offset_1 (tree type, tree
> >
> > Â Â Â Âreturn split_constant_offset_1 (type, var0, subcode, var1, var, off);
> > Â Â Â }
> > + Â ÂCASE_CONVERT:
> > + Â Â Â{
> > + Â Â Â Âsplit_constant_offset (op0, &var0, off);
> > + Â Â Â *var = fold_convert (type, var0);
> > + Â Â Â return true;
> 
> I suppose we arrive with pointer operations here and the case in 
> question also involves pointer conversions?

Yep, there were also the typical fortran int4 -> int8 conversions 
involved, I don't remember if those mattered, though.

> I'm a bit concerned about not converting the offset here in case the 
> conversion was widening -

The returned offset is always of sizetype, not possible to go wider than 
this.

> we'll probably ICE during the recursion in that case.  So, can you 
> restrict this to pointer-to-pointer conversions?

Given the above, should I still do this?


Ciao,
Michael.