This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch]PR rtl-optimization/42691: problematic REG_EQUAL note added to SUBREG
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Jing Yu <jingyu at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 14 Jan 2010 07:38:35 +0100
- Subject: Re: [Patch]PR rtl-optimization/42691: problematic REG_EQUAL note added to SUBREG
- References: <85670fb81001131632j106a8257t3968274ae2b32187@mail.gmail.com>
> This patch is to fix the bug 42691, which is a regression from gcc-4.2.1.
>
> PR rtl-optimization/42691
> * combine.c (try_combine): Clear outdated i3note when dest of I3 is
> replaced.
The patch is OK for mainline and 4.4 branch modulo a couple of things:
1. Add a testcase to gcc.c-torture/execute testsuite; it must be executable
and for example call abort () when it is miscompiled.
2. Describe only the change in the ChangeLog: "Set changed_i3_dest if ... and
tweak comments." Note that comments are ended with double-space-start-slash.
Thanks for fixing this.
--
Eric Botcazou