This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch PR c++/40239

On 01/12/2010 05:58 AM, Dodji Seketeli wrote: 
+	      /* direct-initialize the target with the temporary.  */
+	      if (TREE_CODE (next) == TARGET_EXPR)
+		TARGET_EXPR_DIRECT_INIT_P (next) = true;

The comment is misleading; setting TARGET_EXPR_DIRECT_INIT_P means there isn't a temporary involved. I suppose we ought to enforce that by checking in cp_gimplify_expr that we don't see any TARGET_EXPR with that flag set (because they all get folded away by cp_gimplify_init_expr).

Otherwise OK.

Jason

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]