Re: [PATCH PR/42467 42469] Keep the text before TABs and use TABs at some option help text.

["Joseph S. Myers" <joseph at codesourcery dot com>]

On Fri, 8 Jan 2010, Shujing Zhao wrote:

> Hi, Joseph and all
> 
> As the advices of Joseph's advices on the audit trails to these two bugs, I
> made this patch and tested it. After run "make gcc.pot", the text before the
> TABs would be extracted to gcc.pot.

This patch is OK.

> When I try to translate some strings (keeping the "\t" character, so the
> translated option name would be displayed) at one .po file, make, install and
> change the locale, the option name and help text can be displayed by run
> "/prefix-dir/bin/gcc -v --help". The only problem is it can't be aligned if
> there is only a "\t" character between the option name and help text at the
> translation string. I think maybe it is caused by the length of the string is
> changed. The desirable status should look like the display of "display_help"
> at the gcc.c. But I think that is what the translator should consider.

Did your test use characters whose width in columns is not the same as 
their length in bytes?  If so, I think this is a real bug in GCC - the 
computations of column widths for alignment in opts.c should be using 
gcc_gettext_width rather than strlen and pointer subtraction.  Please file 
a separate PR for this, marked as blocking 40883, if you won't be fixing 
it yourself shortly.

-- 
Joseph S. Myers
joseph@codesourcery.com