This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Fix unportabilities in dg-extract-results.sh


Joseph S. Myers writes:
> On Fri, 21 Nov 2008, Rainer Orth wrote:
> 
> > In the make check output on Solaris 10/x86, I noticed the following errors:
> > 
> > usage: tail [+/-[n][lbc][f]] [file]
> >        tail [+/-[n][l][r|f]] [file]
> > 
> > This is due to the use of tail -n in contrib/dg-extract-results.sh, which
> > isn't portable.  All over the tree, we use tail -<n> instead.
> > 
> > This patch does this and also fixed a typo (two consecutive || signs).
> 
> Why do you think the use of || is a typo?  Piping into a command that 
> doesn't take input from stdin doesn't make sense, but the command with || 
> does (if there are no ^# lines in the output from the first tail command, 
> then use that output by rerunning the command).

[Finishing some old mail threads...]

Of course you're right, sorry for the stupid error.  I've now committed the
change from tail -n 2 to tail -2.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]