This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[Patch, Fortran] PR fortran/22552: -Wimplicit-procedure
- From: Daniel Kraft <d at domob dot eu>
- To: Fortran List <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 26 Dec 2009 11:16:56 +0100
- Subject: [Patch, Fortran] PR fortran/22552: -Wimplicit-procedure
Hi all,
here's a small and straight-forward patch for PR 22552 that adds a new
warning flag -Wimplicit-procedure for procedures that are called but
never explicitly declared. The difference between -Wimplicit-interface
is that this option does not trigger when a procedure is declared
EXTERNAL but still does not have an interface. This is useful for
legacy code, see the PR at
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22552.
Additionally, this is the first "half" of my RFC at
http://gcc.gnu.org/ml/fortran/2009-12/msg00131.html, with Tobias'
proposed documentation change.
No regressions on GNU/Linux-x86-32. Ok for trunk?
Yours,
Daniel
--
Done: Arc-Bar-Cav-Ran-Rog-Sam-Tou-Val-Wiz
To go: Hea-Kni-Mon-Pri
2009-12-25 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Daniel Kraft <d@domob.eu>
PR fortran/22552
* lang.opt (Wimplicit-procedure): New option.
* gfortran.h (struct gfc_option_t): New member `warn_implicit_procedure'
* options.c (gfc_handle_option): Handle -Wimplicit-procedure.
* interface.c (gfc_procedure_use): Warn about procedure never
explicitly declared if requested by the new flag.
* invoke.texi: Document new flag -Wimplicit-procedure.
2009-12-25 Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Daniel Kraft <d@domob.eu>
PR fortran/22552
* gfortran.dg/warn_implicit_procedure_1.f90: New test.
Index: gcc/fortran/interface.c
===================================================================
--- gcc/fortran/interface.c (revision 155464)
+++ gcc/fortran/interface.c (working copy)
@@ -2380,12 +2380,18 @@ gfc_procedure_use (gfc_symbol *sym, gfc_
/* Warn about calls with an implicit interface. Special case
for calling a ISO_C_BINDING becase c_loc and c_funloc
- are pseudo-unknown. */
- if (gfc_option.warn_implicit_interface
- && sym->attr.if_source == IFSRC_UNKNOWN
- && ! sym->attr.is_iso_c)
- gfc_warning ("Procedure '%s' called with an implicit interface at %L",
- sym->name, where);
+ are pseudo-unknown. Additionally, warn about procedures not
+ explicitly declared at all if requested. */
+ if (sym->attr.if_source == IFSRC_UNKNOWN && ! sym->attr.is_iso_c)
+ {
+ if (gfc_option.warn_implicit_interface)
+ gfc_warning ("Procedure '%s' called with an implicit interface at %L",
+ sym->name, where);
+ else if (gfc_option.warn_implicit_procedure
+ && sym->attr.proc == PROC_UNKNOWN)
+ gfc_warning ("Procedure '%s' called at %L is not explicitly declared",
+ sym->name, where);
+ }
if (sym->attr.if_source == IFSRC_UNKNOWN)
{
Index: gcc/fortran/gfortran.h
===================================================================
--- gcc/fortran/gfortran.h (revision 155464)
+++ gcc/fortran/gfortran.h (working copy)
@@ -2103,6 +2103,7 @@ typedef struct
int warn_ampersand;
int warn_conversion;
int warn_implicit_interface;
+ int warn_implicit_procedure;
int warn_line_truncation;
int warn_surprising;
int warn_tabs;
Index: gcc/fortran/lang.opt
===================================================================
--- gcc/fortran/lang.opt (revision 155464)
+++ gcc/fortran/lang.opt (working copy)
@@ -96,6 +96,10 @@ Wimplicit-interface
Fortran Warning
Warn about calls with implicit interface
+Wimplicit-procedure
+Fortran Warning
+Warn about called procedures not explicitly declared
+
Wline-truncation
Fortran Warning
Warn about truncated source lines
Index: gcc/fortran/invoke.texi
===================================================================
--- gcc/fortran/invoke.texi (revision 155464)
+++ gcc/fortran/invoke.texi (working copy)
@@ -137,9 +137,9 @@ and warnings}.
@gccoptlist{-fmax-errors=@var{n} @gol
-fsyntax-only -pedantic -pedantic-errors @gol
-Wall -Waliasing -Wampersand -Warray-bounds -Wcharacter-truncation @gol
--Wconversion -Wimplicit-interface -Wline-truncation -Wintrinsics-std @gol
--Wsurprising -Wno-tabs -Wunderflow -Wunused-parameter -Wintrinsics-shadow @gol
--Wno-align-commons}
+-Wconversion -Wimplicit-interface -Wimplicit-procedure -Wline-truncation @gol
+-Wintrinsics-std -Wsurprising -Wno-tabs -Wunderflow -Wunused-parameter @gol
+-Wintrinsics-shadow -Wno-align-commons}
@item Debugging Options
@xref{Debugging Options,,Options for debugging your program or GNU Fortran}.
@@ -754,6 +754,12 @@ Warn if a procedure is called without an
Note this only checks that an explicit interface is present. It does not
check that the declared interfaces are consistent across program units.
+@item -Wimplicit-procedure
+@opindex @code{Wimplicit-procedure}
+@cindex warnings, implicit procedure
+Warn if a procedure is called that has neither an explicit interface
+nor has been declared as @code{EXTERNAL}.
+
@item -Wintrinsics-std
@opindex @code{Wintrinsics-std}
@cindex warnings, non-standard intrinsics
Index: gcc/fortran/options.c
===================================================================
--- gcc/fortran/options.c (revision 155464)
+++ gcc/fortran/options.c (working copy)
@@ -561,6 +561,10 @@ gfc_handle_option (size_t scode, const c
gfc_option.warn_implicit_interface = value;
break;
+ case OPT_Wimplicit_procedure:
+ gfc_option.warn_implicit_procedure = value;
+ break;
+
case OPT_Wline_truncation:
gfc_option.warn_line_truncation = value;
break;
Index: gcc/testsuite/gfortran.dg/warn_implicit_procedure_1.f90
===================================================================
--- gcc/testsuite/gfortran.dg/warn_implicit_procedure_1.f90 (revision 0)
+++ gcc/testsuite/gfortran.dg/warn_implicit_procedure_1.f90 (revision 0)
@@ -0,0 +1,43 @@
+! { dg-do compile }
+! { dg-options "-Wimplicit-procedure" }
+
+! PR fortran/22552
+! Check for correct -Wimplicit-procedure warnings.
+
+MODULE m
+
+CONTAINS
+
+ SUBROUTINE my_sub ()
+ END SUBROUTINE my_sub
+
+ INTEGER FUNCTION my_func ()
+ my_func = 42
+ END FUNCTION my_func
+
+END MODULE m
+
+SUBROUTINE test (proc)
+ IMPLICIT NONE
+ CALL proc () ! { dg-bogus "is not explicitly declared" }
+END SUBROUTINE test
+
+PROGRAM main
+ USE m
+ EXTERNAL :: ext_sub
+ EXTERNAL :: test
+ INTEGER :: ext_func
+
+ CALL ext_sub () ! { dg-bogus "is not explicitly declared" }
+ PRINT *, ext_func () ! { dg-bogus "is not explicitly declared" }
+ PRINT *, implicit_func () ! { dg-bogus "is not explicitly declared" }
+ CALL my_sub () ! { dg-bogus "is not explicitly declared" }
+ PRINT *, my_func () ! { dg-bogus "is not explicitly declared" }
+ PRINT *, SIN (3.14159) ! { dg-bogus "is not explicitly declared" }
+
+ CALL undef_sub (1, 2, 3) ! { dg-warning "is not explicitly declared" }
+ ! Can't check undefined function, because it needs to be declared a type
+ ! in any case (and the implicit type is enough to not trigger this warning).
+END PROGRAM
+
+! { dg-final { cleanup-modules "m" } }