Re: [patch, testsuite, libgomp.fortran] darwin no longer requires static linkage to access TLS.

[IainS <developer at sandoe-acoustics dot co dot uk>]

Thanks Janis,

corrections below, I don't have commit access so this is as far as I  
can go.

On 21 Dec 2009, at 19:10, Janis Johnson wrote:

> On Thu, 2009-12-17 at 20:33 +0000, IainS wrote:
> > Hi All,
> >
> > As discussed on IRC last night, Darwin targets no longer need - 
> > static-
> > libgcc to provide TLS.  Consequently, the two tests that force this
> > (libgomp.fortran/crayptr2.f90 and libgomp.fortran/pr32550.f90) can be
> > tidied.
> >
> > in each case:
> > -! { dg-options "-static-libgcc" { target *-*-darwin* } }
> > +! { dg-require-effective-target tls_runtime }
> >
> > this is (IMO) the correct situation in any event - it seems  
> > misleading
> > to force non-standard options to make a target pass a few tests.
> > checked on darwin9 ppc/i686 and darwin10 (thanks to Dominique).
> >
> > cheers,
> > Iain
> >
> > ====
> >
> >
> > 2009-12-17 Iain Sandoe <iain.sandoe@sandoe-acoustics.co.uk>
> >
> > 	*libgomp/testsuite/libgomp.fortran/crayptr2.f90 remove forced static
> > linkage for darwin, protect the test with require-effective-target
> > tls_runtime
> > 	*libgomp/testsuite/libgomp.fortran/pr32550.f90 remove forced static
> > linkage for darwin, protect the test with require-effective-target
> > tls_runtime
>
> OK, but fix the ChangeLog entry.  This will be in libgomp/ChangeLog,  
> so
> don't include "libgomp".  Leave a space after '*' for each file.  Add
> line breaks so that each line is 78 characters or less.

libgomp/Changelog:
2009-12-17 Iain Sandoe <iain.sandoe@sandoe-acoustics.co.uk>

	* testsuite/libgomp.fortran/crayptr2.f90: Remove forced static linkage
	for darwin, protect the test with require-effective-target tls_runtime.
	* testsuite/libgomp.fortran/pr32550.f90: Ditto.

Attachment: libgomp.fortran.testsuite.diff.txt
Description: Text document

cheers,
Iain