This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix comdat optimized same body virtual destructors (PR c++/42317)
On Tue, 8 Dec 2009, Jason Merrill wrote:
> On 12/08/2009 10:35 AM, Jan Hubicka wrote:
> > I planned to have comdat groups mixing varpool and cgraph nodes for this.
> > Are we never combining variables and functions into single chunk?
>
> Not currently.
>
> > I can not approve C++ bits, but I was more thinking of using
> > DECL_COMDAT_GROUP in cgraph code + simple assembler name driven hash to make
> > cgraph discover this
> > without frontend assistance. I am happy with both sollutions (and I don't
> > know
> > if mine works in all cases)
>
> I had been thinking along those lines as well, it seems like it would be more
> robust. When I said that to Jakub he suggested that could happen for 4.6.
I also think this would be the better solution. But I'm happy
with either way if it fixes the bug for 4.5 - we can indeed revisit
in 4.6 (though both approaches look like having the same complexity
and risks).
Richard.