This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix comdat optimized same body virtual destructors (PR c++/42317)

From: Jason Merrill <jason at redhat dot com>
To: Jan Hubicka <hubicka at ucw dot cz>
Cc: Jakub Jelinek <jakub at redhat dot com>, Richard Guenther <rguenther at suse dot de>, gcc-patches at gcc dot gnu dot org
Date: Tue, 08 Dec 2009 10:40:26 -0500
Subject: Re: [PATCH] Fix comdat optimized same body virtual destructors (PR c++/42317)
References: <20091207182839.GR22813@hs20-bc2-1.build.redhat.com> <20091208153519.GA21863@kam.mff.cuni.cz>

On 12/08/2009 10:35 AM, Jan Hubicka wrote:

I planned to have comdat groups mixing varpool and cgraph nodes for this.
Are we never combining variables and functions into single chunk?

Not currently.

I can not approve C++ bits, but I was more thinking of using DECL_COMDAT_GROUP in cgraph code + simple assembler name driven hash to make cgraph discover this
without frontend assistance.  I am happy with both sollutions (and I don't know
if mine works in all cases)

I had been thinking along those lines as well, it seems like it would be more robust. When I said that to Jakub he suggested that could happen for 4.6.

Jason

Follow-Ups:
- Re: [PATCH] Fix comdat optimized same body virtual destructors (PR c++/42317)
  - From: Richard Guenther

References:
- [PATCH] Fix comdat optimized same body virtual destructors (PR c++/42317)
  - From: Jakub Jelinek
- Re: [PATCH] Fix comdat optimized same body virtual destructors (PR c++/42317)
  - From: Jan Hubicka

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]