This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch][graphite]Add run time check and cleanup autopar test cases.
Li,
Thank you for enabling runtime checks for this suite,
It was long overdue...
> > There are changes to test autopar/outer-2.c that have nothing
> > to do with this patch. If those changes were intended, please
> > move them to a separate patch.
>
> Yes, this testcase have a runtime error, so I changed the testcase
> to fix this. This now located in 02-cleanup.patch.
>
Yes, this fix is good.
Thanks..
> >
> > Tests pr39500-1.c and pr39500-2.c were not changed, was that on
> > purpose? They both have a "main" look as if they could be run.
> >
> Due to the pr39500, it's a compile time bug, the main function and
> abort check seems a little confused, so I cleanup the two testcases.
> Also in 02-cleanup.patch.
>
I'm not so sure about this change.
For me there's no compile time or runtime problem.
Did you get some out-of-memory failure?
> > With those changes the patch is OK with me, but wait for input
> > from Razya as well.
> Sure.
Thanks,
Razya