This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH, libjava: silence more warnings
- From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- To: tromey at redhat dot com
- Cc: Dave Korn <dave dot korn dot cygwin at googlemail dot com>, Ben Elliston <bje at au1 dot ibm dot com>, java <java at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Andrew Haley <aph at redhat dot com>
- Date: Tue, 01 Dec 2009 20:31:27 +0000
- Subject: Re: PATCH, libjava: silence more warnings
- References: <1259691731.6215.6.camel@bapbop> <4B1564E4.6060009@gmail.com> <m3d42yo4xf.fsf@fleche.redhat.com>
Tom Tromey wrote:
>>>>>> "Dave" == Dave Korn <dave.korn.cygwin@googlemail.com> writes:
>
> Dave> Ben Elliston wrote:
>>> ::java::lang::String *
>>> -java::net::VMURLConnection::guessContentTypeFromBuffer (jbyteArray bytes,
>>> - jint valid)
>>> +java::net::VMURLConnection::guessContentTypeFromBuffer (jbyteArray bytes __attribute__ ((unused)),
>>> + jint valid __attribute__ ((unused)))
>
> Dave> There's a #define MAYBE_UNUSED in include/jvm.h, as used in
> Dave> java/lang/natClass.cc. But maybe jvm.h isn't available here?
>
> It is ok to include jvm.h from any of the CNI code.
>
> But, it is also ok to just use an unadorned __attribute__. We know this
> code can only be compiled by g++.
... given which, it's hardly worth adding a new header dependency just to
get the macro. Right, thanks for clarifying that.
cheers,
DaveK