This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Use aliases instead of separate copies for !DECL_ONE_ONLY C[12] ctors or D[12] dtors with identical bodies (PR c++/3187, take 3)

From: Jason Merrill <jason at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Jan Hubicka <hubicka at ucw dot cz>, Jan Hubicka <jh at suse dot cz>, gcc-patches at gcc dot gnu dot org
Date: Mon, 16 Nov 2009 23:06:36 -0500
Subject: Re: [PATCH] Use aliases instead of separate copies for !DECL_ONE_ONLY C[12] ctors or D[12] dtors with identical bodies (PR c++/3187, take 3)
References: <20091111141006.GL14664@tyan-ft48-01.lab.bos.redhat.com> <20091113175921.GW14664@tyan-ft48-01.lab.bos.redhat.com> <20091113191955.GC29899@atrey.karlin.mff.cuni.cz> <20091113193505.GZ14664@tyan-ft48-01.lab.bos.redhat.com> <20091113200423.GS24874@kam.mff.cuni.cz> <20091116174144.GE14664@tyan-ft48-01.lab.bos.redhat.com>

On 11/16/2009 12:41 PM, Jakub Jelinek wrote:

+    else if (DECL_NAME (clone) == deleting_dtor_identifier)
+      fns[2] = clone;

Why did you add the third slot to fns?

also making the complete
cdtor to be the defined function and base cdtor be an alias to it.

I think I prefer having the base cdtor be the defined one, since it's conceptually a subroutine of the complete cdtor.

Jason

Follow-Ups:
- Re: [PATCH] Use aliases instead of separate copies for !DECL_ONE_ONLY C[12] ctors or D[12] dtors with identical bodies (PR c++/3187, take 3)
  - From: Jakub Jelinek

References:
- [PATCH] Use aliases instead of separate copies for !DECL_ONE_ONLY C[12] ctors or D[12] dtors with identical bodies (PR c++/3187)
  - From: Jakub Jelinek
- [PATCH] Use aliases instead of separate copies for !DECL_ONE_ONLY C[12] ctors or D[12] dtors with identical bodies (PR c++/3187, take 2)
  - From: Jakub Jelinek
- Re: [PATCH] Use aliases instead of separate copies for !DECL_ONE_ONLY C[12] ctors or D[12] dtors with identical bodies (PR c++/3187, take 2)
  - From: Jan Hubicka
- Re: [PATCH] Use aliases instead of separate copies for !DECL_ONE_ONLY C[12] ctors or D[12] dtors with identical bodies (PR c++/3187, take 2)
  - From: Jakub Jelinek
- Re: [PATCH] Use aliases instead of separate copies for !DECL_ONE_ONLY C[12] ctors or D[12] dtors with identical bodies (PR c++/3187, take 2)
  - From: Jan Hubicka
- [PATCH] Use aliases instead of separate copies for !DECL_ONE_ONLY C[12] ctors or D[12] dtors with identical bodies (PR c++/3187, take 3)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]