This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fix -fcompare-debug regression in free_lang_data


> Hm, no idea why it was there in the first place.  A patch to remove it
> is pre-approved (if that passes bootstrap & regtest of course).

Because of the FIXME:

  /* FIXME.  Remove after save_debug_info is working.  */
  if (!(flag_generate_lto
	|| (!in_lto_p
	    && !flag_gtoggle && debug_info_level <= DINFO_LEVEL_TERSE)))
    return 0;

If you remove the flag_gtoggle test, you will end up generating different code 
with -gtoggle -g0 and -gtoggle -g for the languages whose boolean_type_node 
is changed, thus breaking bootstrap comparison.

Of course, as Alexandre said, that would probably be a good thing because 
different code is already generated for these languages at -g and -g0 due to 
the boolean_type_node hack, but it's hidden by -gtoggle.

-- 
Eric Botcazou


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]