This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch][graphite] Check cloog revision when configure.

On Sat, Nov 7, 2009 at 2:59 AM, Paolo Bonzini <bonzini@gnu.org> wrote:
> If this is the patch:
>
> - ?#if CLOOG_VERSION_MAJOR != 0 || CLOOG_VERSION_MINOR != 15
> + ?#if CLOOG_VERSION_MAJOR != 0 || CLOOG_VERSION_MINOR != 15 ||
> CLOOG_VERSION_REVISION < 5
> ? choke me
> ? #endif

Em, this is the patch.

-  #if CLOOG_VERSION_MAJOR != 0 || CLOOG_VERSION_MINOR != 15
+  #if CLOOG_VERSION_MAJOR != 0 || CLOOG_VERSION_MINOR != 15 ||
CLOOG_VERSION_REVISION < 4

 I have noticed in Sebastian's last patch, the
CLOOG_VERSION_REVISION will not allow revision 4.

@Sebastian, is there some special reason for this? I have tested
cloog 0.15.4, and it works (at least) with aermod in polyhedral benchmark.

>
> it is fine as is, however consider future proofing it by allowing 0.16 and
> 1.0 to pass the test.
>
> Paolo
>

Thanks,
Li
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]