This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Don't use a temporary directory in the lto plugin
- From: Cary Coutant <ccoutant at google dot com>
- To: Rafael Espindola <espindola at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 4 Nov 2009 16:50:50 -0800
- Subject: Re: [patch] Don't use a temporary directory in the lto plugin
- References: <38a0d8450911041146v2c9ac2eaub3fd1aaefbc6a102@mail.gmail.com>
> 2009-11-04 ?Rafael Avila de Espindola ?<espindola@google.com>
>
> ? ? ? ?* lto-plugin.c (temp_obj_dir_name): Remove.
> ? ? ? ?(arguments_file_name): New.
> ? ? ? ?(free_2): Free arguments_file_name instead of temp_obj_dir_name.
> ? ? ? ?(exec_lto_wrapper): ?Create arguments file with make_temp_file.
> ? ? ? ?(cleanup_handler): Don't remove the temporary directory. Remove the
> ? ? ? ?arguments file.
> ? ? ? ?(onload): Don't create the temporary directory.
+ arguments_file_name = make_temp_file("");
Need a space before the '('.
+ if (arguments_file_name)
+ {
+ t = unlink (arguments_file_name);
+ check (t == 0, LDPL_FATAL, "could not unlink arguments file");
+ }
The then block needs to be indented.
This is OK with those changes.
-cary