This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix miscompilation in output_constant_def

From: Richard Henderson <rth at redhat dot com>
To: Maxim Kuvyrkov <maxim at codesourcery dot com>
Cc: Mark Mitchell <mark at codesourcery dot com>, Jeff Law <law at redhat dot com>, meloun at miracle dot cz, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Wed, 04 Nov 2009 10:17:30 -0800
Subject: Re: [PATCH] Fix miscompilation in output_constant_def
References: <491DB2C6.7658.C2CA2E3@meloun.miracle.cz> <49207382.5000305@codesourcery.com> <492C4A04.9090100@redhat.com> <4A4105C6.4080006@codesourcery.com> <4A497BDB.8040409@codesourcery.com> <4A50FD42.10100@codesourcery.com> <4A510421.8080608@codesourcery.com> <4A56333B.20507@codesourcery.com> <4AF1C117.7040104@codesourcery.com>

On 11/04/2009 09:59 AM, Maxim Kuvyrkov wrote:

3. Reload pass of the first function in compilation unit substitutes
(symbol_ref) for a register inside (mem), the result is (mem (reg)).

The question is, how did the MEM from the VAR_DECL escape into the rtl stream in the first place? In expand_expr_real, we have

       decl_rtl = DECL_RTL (exp);
     expand_decl_rtl:
       gcc_assert (decl_rtl);
       decl_rtl = copy_rtx (decl_rtl);

so it's not happening there...

r~

Follow-Ups:
- Re: [PATCH] Fix miscompilation in output_constant_def
  - From: Maxim Kuvyrkov

References:
- Re: [PATCH] Fix miscompilation in output_constant_def
  - From: Maxim Kuvyrkov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]