This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add MIPS64r2 support to <u>mulsidi3_64bit
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: Adam Nemet <anemet at caviumnetworks dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 03 Nov 2009 21:29:26 +0000
- Subject: Re: [PATCH] Add MIPS64r2 support to <u>mulsidi3_64bit
- References: <19169.62748.654396.688151@ropi.home> <87hbtpt9w0.fsf@firetop.home> <19171.63913.618530.372027@ropi.home>
I only noticed later that a couple of the comments need to be updated:
Adam Nemet <anemet@caviumnetworks.com> writes:
> + ;; OP0 <- LO, OP4 <- HI
> + (set (match_dup 0) (match_dup 5))
> + (set (match_dup 4) (unspec:DI [(match_dup 3)] UNSPEC_MFHI))
>
> ;; Zero-extend OP4.
> - (set (match_dup 4)
> - (ashift:DI (match_dup 4)
> + (set (match_dup 0)
> + (ashift:DI (match_dup 0)
> (const_int 32)))
> - (set (match_dup 4)
> - (lshiftrt:DI (match_dup 4)
> + (set (match_dup 0)
> + (lshiftrt:DI (match_dup 0)
> (const_int 32)))
>
> ;; Shift OP0 into place.
> - (set (match_dup 0)
> - (ashift:DI (match_dup 0)
> + (set (match_dup 4)
> + (ashift:DI (match_dup 4)
> (const_int 32)))
Here's what I applied.
Richard
gcc/
* config/mips/mips.md: Fix typos.
Index: gcc/config/mips/mips.md
===================================================================
--- gcc/config/mips/mips.md 2009-11-03 21:28:08.000000000 +0000
+++ gcc/config/mips/mips.md 2009-11-03 21:28:08.000000000 +0000
@@ -1930,7 +1930,7 @@ (define_split
(set (match_dup 0) (match_dup 5))
(set (match_dup 4) (unspec:DI [(match_dup 3)] UNSPEC_MFHI))
- ;; Zero-extend OP4.
+ ;; Zero-extend OP0.
(set (match_dup 0)
(ashift:DI (match_dup 0)
(const_int 32)))
@@ -1938,7 +1938,7 @@ (define_split
(lshiftrt:DI (match_dup 0)
(const_int 32)))
- ;; Shift OP0 into place.
+ ;; Shift OP4 into place.
(set (match_dup 4)
(ashift:DI (match_dup 4)
(const_int 32)))