This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][LTO][RFC] AR archive support for LTO
Rafael Espindola wrote:
>> Things I am not 100% happy with in the patch:
>>
>> *) The hack in gcc.c. What is the correct solution? Making gcc.c
>> ignore filenames with a @ in it?
> OK. I fixed both. What do you think of the attached patch?
Maybe it should take care not to match on a filename where the first
character is '@', to avoid any danger of clashing with the "@file"
command-line file-substitution syntax? I'm not sure where that gets expanded
(possibly in libiberty?), but it would be more robust to guard against it than
to rely on it happening earlier... someone might refactor this code one day
without realising, for example.
cheers,
DaveK