This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Close temporary files in claim_file_handler
- From: Toon Moene <toon at moene dot org>
- To: Rafael Espindola <espindola at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Cary Coutant <ccoutant at google dot com>, Richard Guenther <rguenther at suse dot de>
- Date: Sat, 31 Oct 2009 14:17:13 +0100
- Subject: Re: [patch] Close temporary files in claim_file_handler
- References: <38a0d8450910300827w58b5d9bcj8d8ef4a7014b1e75@mail.gmail.com> <4AEB48CD.8000507@moene.org>
Toon Moene wrote:
Tomorrow I'll present a patch that adds reasoning to the dumps of ipa
inlining for "called-once" routines (currently it only says: Inline
limit reached <slap> don't ask again ;-).
Is the following acceptable (even in phase 3) ?
2009-10-31 Toon Moene <toon@moene.org>
* ipa-inline.c (cgraph_decide_inlining):
Include reason for not inlining
called-once functions in dump file.
Index: gcc/ipa-inline.c
===================================================================
--- gcc/ipa-inline.c (revision 153775)
+++ gcc/ipa-inline.c (working copy)
@@ -1233,6 +1233,7 @@
&& !DECL_EXTERNAL (node->decl)
&& !DECL_COMDAT (node->decl))
{
+ cgraph_inline_failed_t reason;
old_size = overall_size;
if (dump_file)
{
@@ -1246,7 +1247,7 @@
}
if (cgraph_check_inline_limits (node->callers->caller, node,
- NULL, false))
+ &reason, false))
{
cgraph_mark_inline (node->callers);
if (dump_file)
@@ -1261,7 +1262,8 @@
{
if (dump_file)
fprintf (dump_file,
- " Inline limit reached, not inlined.\n");
+ " Not inlined because %s.\n",
+ cgraph_inline_failed_string (reason));
}
}
}
Thanks in advance,
--
Toon Moene - e-mail: toon@moene.org - phone: +31 346 214290
Saturnushof 14, 3738 XG Maartensdijk, The Netherlands
At home: http://moene.org/~toon/
Progress of GNU Fortran: http://gcc.gnu.org/gcc-4.5/changes.html