Re: PATCH: PR target/40838: gcc shouldn't assume that the stack is aligned

[Richard Guenther <richard dot guenther at gmail dot com>]

On Wed, Oct 21, 2009 at 5:53 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Oct 21, 2009 at 2:05 AM, Michael Matz <matz@suse.de> wrote:
>> Hi,
>>
>> On Tue, 20 Oct 2009, H.J. Lu wrote:
>>
>>> > Here is a new patch. I added hard_stack_alignment, moved
>>> > update_stack_boundary after RTL expansion and updated
>>> > ix86_function_ok_for_sibcall to deal with it. ?Any comments?
>>
>> Well, I think this approach of tracking the required alignment (in
>> gen_reg_rtx especially) is indeed better.
>>
>
> Here is the updated patch. We don't need to add
> hard_stack_alignment. ?We can initialize
> stack_alignment_estimated to 0 and check it instead.
> Tested it on Linux/x86-64 with -m32. OK for trunk?

Ok.

Thanks,
Richard.

> Thanks.
>
>
> --
> H.J.
> ---
> gcc/
>
> 2009-10-21 ?H.J. Lu ?<hongjiu.lu@intel.com>
>
> ? ? ? ?PR target/40836
> ? ? ? ?* cfgexpand.c (expand_stack_alignment): Call update_stack_boundary
> ? ? ? ?first. ?Move assert on stack_alignment_estimated just before
> ? ? ? ?setting stack_realign_needed.
> ? ? ? ?(gimple_expand_cfg): Initialize stack_alignment_estimated to 0.
> ? ? ? ?Don't call update_stack_boundary.
>
> ? ? ? ?* config/i386/i386.c (ix86_minimum_incoming_stack_boundary): New.
> ? ? ? ?(verride_options): Don't check ix86_force_align_arg_pointer here.
> ? ? ? ?(ix86_function_ok_for_sibcall): Use it.
> ? ? ? ?(ix86_update_stack_boundary): Likewise.
>
> ? ? ? ?* config/i386/i386.h (STACK_REALIGN_DEFAULT): Update comments.
>
> gcc/testsuite/
>
> 2009-10-21 ?H.J. Lu ?<hongjiu.lu@intel.com>
>
> ? ? ? ?PR target/40838
> ? ? ? ?* gcc.target/i386/incoming-6.c: New.
> ? ? ? ?* gcc.target/i386/incoming-7.c: Likewise.
> ? ? ? ?* gcc.target/i386/incoming-8.c: Likewise.
> ? ? ? ?* gcc.target/i386/incoming-9.c: Likewise.
> ? ? ? ?* gcc.target/i386/incoming-10.c: Likewise.
> ? ? ? ?* gcc.target/i386/incoming-11.c: Likewise.
> ? ? ? ?* gcc.target/i386/incoming-12.c: Likewise.
> ? ? ? ?* gcc.target/i386/incoming-13.c: Likewise.
> ? ? ? ?* gcc.target/i386/incoming-14.c: Likewise.
> ? ? ? ?* gcc.target/i386/incoming-15.c: Likewise.
> ? ? ? ?* gcc.target/i386/pr37843-4.c: Likewise.
>