This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][LTO] Some TBAA fixes


On Mon, 26 Oct 2009, Richard Guenther wrote:

> On Sun, 25 Oct 2009, Richard Guenther wrote:
> 
> > 
> > This addresses two things.  First Alexandre reported issues with
> > -fcompare-debug and fld calling get_alias_set - the patch removes
> > it (and has to adjust re-setting types_compatible_p, the langhook
> > is needed if late initializing the FE specific type hashtable
> > in the get_alias_set langhook.  Ugh).
> > 
> > The 2nd issue is alias-sets of pointers.  While I believe we
> > should move to a middle-end-only solution for get_alias_set for
> > 4.5 I'll only try to cover up for bugs uncovered with LTO.  This
> > implements the cheapest way (and possibly enough precision anyway)
> > for pointer types - the patch mentions all the issues that arise.
> > 
> > Bootstrapped and tested on x86_64-unknown-linux-gnu, SPEC 2006
> > tested where it fixes the calculix miscompare (which might be
> > as well a calculix bug, not a LTO bug - but after all, we
> > should be reasonable and SPEC 2006 seems to be a reasonable
> > sanity test).
> > 
> > Ok for trunk?
> 
> Actually we have to still query integer type alias-sets before
> messing with char_type_node and friends.  Otherwise interesting
> things happen.
> 
> Thus, the following is an updated patch.  Ok for trunk?

I have committed this now based on the fact that it is all middle-end
anyway.

Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]