This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: LTO/WHOPR summary streaming fixes


> On Thu, 22 Oct 2009, Richard Guenther wrote:
> 
> > On Thu, 22 Oct 2009, Richard Guenther wrote:
> > 
> > > On Thu, 22 Oct 2009, Jan Hubicka wrote:
> > > 
> > > > Hi,
> > > > this should be final version of patch.  Tested on x86_64-linux and also
> > > > Richard kindly tested it works with Spec2006.
> > > > The patch fixes ICE in ipa-cp seen on libquantum. OK?
> > > 
> > > Ok.  I'll think about the fixup problem.  I think we can easily delay
> > > cgraph node merging until after fixup, then read in the summaries and
> > > then apply the node merging.
> > 
> > Like this (untested).
> 
> Which doesn't (of course) work.  The following sort-of does, with
> some extra WHOPR ICEs.

Thanks,
I will shortly test and send patch disabling indirect inlining at WPA stage (so we don't
get into confussion with jump functions). In order to do indirect inlining at WPA we
will need to fix WPA's dealing with passes to not run inliner manually (so we skip reading
of summaries that happens in ipa-cp or inliner depending on -fipa-cp flag) and
to add streaming of indirect call summaries Martin promised to work on.

THe patch makes sense to me, so it would be nice to get it into mainline so we can
fix ipa-reference WRT -fwhole-program.

Honza


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]