This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Use simplify_replace_rtx rather than wrap_constant
Richard Sandiford <rdsandiford@googlemail.com> writes:
> Jakub Jelinek <jakub@redhat.com> writes:
>> In your handling of UNSPEC, I don't understand the copy_rtx, I think
>> currently simplify_replace_rtx doesn't guarantee 100% unsharing of
>> everything, so I think you should unshare only the operands where recursive
>> call actually changed something.
>
> That was the reason for my PS comment. I think the inconsistent
> sharing is actually a bug, but I don't want to lump too many changes
> together.
OTOH, I guess the other simplify_* functions are really only suitable
for cases where you either keep the original expression or the new one,
not both. Sorry for the noise. ;(
Richard