This is the mail archive of the
mailing list for the GCC project.
Re: LTO/WHOPR summary streaming fixes
On Tue, Oct 20, 2009 at 11:09:54AM -0400, Diego Novillo wrote:
> 2009/10/20 Jan Hubicka <firstname.lastname@example.org>:
> > Note that whole ipacp file follows the scheme without empty line
> > after function comment. We probably should reformat it, but since Martin has
> > number of pending patches here, we probably could wait for next stage1?
> No need to wait until the next stage1. Formatting fixes can be done
> in stage3 too. But, sure, if Martin has other patches, he can roll
> them in.
The only patch that touches ipa-cp.c (as opposed to ipa-prop.[ch]) in
any way worth mentioning is implementation of true cloning (posted in
August as a work-in-progress patch:
http://gcc.gnu.org/ml/gcc-patches/2009-08/msg00290.html). Even though
it also specifically adds a fair number of blank lines after function
comments, it certainly isn't stage3 material. Thus, I'll be happy if
formatting patches for this file could be postponed for a while.
OTOH, there will be other changes to the file that will cause me
conflicts too so I will manage if someone does it soon. Nevertheless,
as I want to rewrite a big portion of the file, at the moment I do not
intend to go through it and reformat what I will propose to remove
anyway. Last but not least, new code can be formatted well from the
beginning, that is not an issue at all.