This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [testsuite] fix testsuite/41659, target or xfail with dg-lto-do
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: janis187 at us dot ibm dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 12 Oct 2009 22:02:12 +0200
- Subject: Re: [testsuite] fix testsuite/41659, target or xfail with dg-lto-do
- References: <1255367997.6053.0.camel@janis-laptop>
On Mon, Oct 12, 2009 at 7:19 PM, Janis Johnson <janis187@us.ibm.com> wrote:
> The test directive dg-lto-do does not support target and xfail causes
> and ignores them. ?That behavior is documented in the section on LTO
> testing in the GCC internals manual, but there was no warning or error
> about it. ?This patch fixes a test that tries to skip a test with a
> "target" clause and reports an error for using "target" or "xfail" with
> that directive.
>
> Tested on powerpc64-linux by running lto.exp for c,c++,fortran, checked
> in on trunk.
>
> 2009-10-12 ?Janis Johnson ?<janis187@us.ibm.com>
>
> ? ? ? ?PR testsuite/41659
> ? ? ? ?* gcc.dg/lto/20090914-2.c: Use dg-skip-if to skip test.
> ? ? ? ?* lib/lto.exp (lto-get-options-main): Report error for using "target"
> ? ? ? ?or "xfail" with dg-lto-dg.
>
> Index: gcc/testsuite/gcc.dg/lto/20090914-2_0.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/lto/20090914-2_0.c ? ? (revision 152593)
> +++ gcc/testsuite/gcc.dg/lto/20090914-2_0.c ? ? (working copy)
> @@ -1,4 +1,5 @@
> -/* { dg-lto-do run { target x86_64-*-* i?86-*-* } } */
> +/* { dg-lto-do run */
Hmm, I miss a } here and
> +/* { dg-skip-if "x86 only" { ! { x86_64-*-* i?86-*-* } } { "*" } { "" } }
a */ here.
But maybe you noticed and checked in sth different.
Thanks btw for fixing this.
Richard.