This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Use GCC_HEADER_STDINT instead of stdint.h
- From: Rafael Espindola <espindola at google dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Rainer Orth <ro at techfak dot uni-bielefeld dot de>, "Joseph S. Myers" <joseph at codesourcery dot com>, rguenth at gcc dot gnu dot org, Cary Coutant <ccoutant at google dot com>
- Date: Fri, 9 Oct 2009 13:15:59 -0400
- Subject: Re: [patch] Use GCC_HEADER_STDINT instead of stdint.h
- References: <38a0d8450910090739w32225021paf639e1101d8e4b3@mail.gmail.com> <mcrskds7fll.fsf@dhcp-172-17-9-151.mtv.corp.google.com>
> I'm not sure about this change. ÂAs far as I can tell, this is only
> being suggested for a single instance of uint64_t. ÂI note that the
> gcc configure script already calls AC_TYPE_UINT64_T (indirectly via
> GCC_STDINT_TYPES). ÂI think it might be simpler to do something like
>
> #ifdef HAVE_STDINT_H
> #include <stdint.h>
> #elif defined(HAVE_INTTYPES_H)
> #include <inttypes.h>
> #endif
> #include <sys/types.h>
> #if !defined(HAVE_STDINT_H) && !defined(HAVE_INTTYPES_H) && !defined(HAVE_UINT64_T) && !defined(uint64_t)
> #error can not find uint64_t type
> #endif
I think the attached patch does what you suggested. I tested it on Linux.
Rainer, can you check that this patch fixes the problem on systems without
stdint.h or inttypes.h?
include/
2009-10-09 Rafael Avila de Espindola <espindola@google.com>
PR40790
* plugin-api.h: Don't include stdint.h unconditionally.
lto-plugin/
2009-10-09 Rafael Avila de Espindola <espindola@google.com>
PR40790
* configure: Regenerate.
* Makefile.in: Regenerate.
* configure.ac: Add AC_TYPE_UINT64_T.
* aclocal.m4: Regenerate.
> Ian
>
Thanks,
--
Rafael Ãvila de EspÃndola
Index: include/plugin-api.h
===================================================================
--- include/plugin-api.h (revision 152593)
+++ include/plugin-api.h (working copy)
@@ -26,8 +26,17 @@
#ifndef PLUGIN_API_H
#define PLUGIN_API_H
+#ifdef HAVE_STDINT_H
#include <stdint.h>
+#elif defined(HAVE_INTTYPES_H)
+#include <inttypes.h>
+#endif
#include <sys/types.h>
+#if !defined(HAVE_STDINT_H) && !defined(HAVE_INTTYPES_H) && \
+ !defined(HAVE_UINT64_T) && !defined(uint64_t)
+#error can not find uint64_t type
+#endif
+#include <sys/types.h>
#ifdef __cplusplus
extern "C"
Index: lto-plugin/configure.ac
===================================================================
--- lto-plugin/configure.ac (revision 152593)
+++ lto-plugin/configure.ac (working copy)
@@ -7,6 +7,7 @@
AC_ARG_VAR(LIBELFINC,[How to find libelf include files])
AM_PROG_LIBTOOL
AC_SUBST(target_noncanonical)
+AC_TYPE_UINT64_T
AC_CONFIG_FILES(Makefile)
AC_OUTPUT
AC_SYS_LARGEFILE