Re: Revert unintended changes

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Thu, Oct 1, 2009 at 12:12 AM, Gabriel Dos Reis <gdr@cs.tamu.edu> wrote:
>
> Hi Jason,
>
> ?When I committed the constexpr change, I used the wrong local tree
> therefore end up committing changes that were not intended -- not
> present in any of the versions you've seen and reviewed. ?The unwanted
> commit changed some make_node() to cxx_make_type(). ?This patch reverts
> that. I also took the opportunity to remove two obsolete ChangeLog
> entries from that same commit.
> OK?
>

Your constexpr change caused:

http://gcc.gnu.org/ml/gcc-regression/2009-10/msg00007.html

FAIL: g++.dg/lookup/friend12.C  (test for errors, line 9)
FAIL: g++.dg/lookup/friend12.C (internal compiler error)
FAIL: g++.dg/lookup/friend12.C (test for excess errors)
FAIL: g++.dg/parse/dtor6.C (internal compiler error)
FAIL: g++.dg/parse/dtor6.C (test for excess errors)
FAIL: g++.dg/parse/local-class1.C (internal compiler error)
FAIL: g++.dg/parse/local-class1.C (test for excess errors)
FAIL: g++.dg/template/friend17.C (internal compiler error)
FAIL: g++.dg/template/friend17.C (test for excess errors)
FAIL: g++.dg/template/memfriend2.C (internal compiler error)
FAIL: g++.dg/template/memfriend2.C (test for excess errors)
FAIL: g++.dg/template/memfriend4.C (internal compiler error)
FAIL: g++.dg/template/memfriend4.C (test for excess errors)
FAIL: g++.dg/template/memfriend5.C (internal compiler error)
FAIL: g++.dg/template/memfriend5.C (test for excess errors)
FAIL: g++.dg/template/memfriend6.C  (test for errors, line 11)
FAIL: g++.dg/template/memfriend6.C  (test for errors, line 12)
FAIL: g++.dg/template/memfriend6.C  (test for errors, line 13)
FAIL: g++.dg/template/memfriend6.C  (test for errors, line 20)
FAIL: g++.dg/template/memfriend6.C  (test for errors, line 21)
FAIL: g++.dg/template/memfriend6.C  (test for errors, line 22)
FAIL: g++.dg/template/memfriend6.C (internal compiler error)
FAIL: g++.dg/template/memfriend6.C (test for excess errors)
FAIL: g++.dg/template/memfriend7.C  (test for errors, line 101)
FAIL: g++.dg/template/memfriend7.C  (test for errors, line 107)
FAIL: g++.dg/template/memfriend7.C  (test for errors, line 113)
FAIL: g++.dg/template/memfriend7.C  (test for errors, line 18)
FAIL: g++.dg/template/memfriend7.C  (test for errors, line 39)
FAIL: g++.dg/template/memfriend7.C  (test for errors, line 45)
FAIL: g++.dg/template/memfriend7.C  (test for errors, line 51)
FAIL: g++.dg/template/memfriend7.C  (test for errors, line 57)
FAIL: g++.dg/template/memfriend7.C  (test for errors, line 63)
FAIL: g++.dg/template/memfriend7.C  (test for errors, line 77)
FAIL: g++.dg/template/memfriend7.C  (test for errors, line 83)
FAIL: g++.dg/template/memfriend7.C  (test for errors, line 89)
FAIL: g++.dg/template/memfriend7.C  (test for errors, line 95)
FAIL: g++.dg/template/memfriend7.C  (test for warnings, line 119)
FAIL: g++.dg/template/memfriend7.C  (test for warnings, line 120)
FAIL: g++.dg/template/memfriend7.C  (test for warnings, line 121)
FAIL: g++.dg/template/memfriend7.C  (test for warnings, line 122)
FAIL: g++.dg/template/memfriend7.C  (test for warnings, line 123)
FAIL: g++.dg/template/memfriend7.C  (test for warnings, line 124)
FAIL: g++.dg/template/memfriend7.C  (test for warnings, line 127)
FAIL: g++.dg/template/memfriend7.C  (test for warnings, line 131)
FAIL: g++.dg/template/memfriend7.C (internal compiler error)
FAIL: g++.dg/template/memfriend7.C (test for excess errors)
FAIL: g++.dg/template/new6.C (internal compiler error)
FAIL: g++.dg/template/new6.C (test for excess errors)
FAIL: g++.old-deja/g++.brendan/crash18.C  (test for errors, line 11)
FAIL: g++.old-deja/g++.brendan/crash18.C  (test for errors, line 17)
FAIL: g++.old-deja/g++.brendan/crash18.C (internal compiler error)
FAIL: g++.old-deja/g++.brendan/crash18.C (test for excess errors)
FAIL: g++.old-deja/g++.jason/scoping12.C  (test for errors, line 9)
FAIL: g++.old-deja/g++.jason/scoping12.C (internal compiler error)
FAIL: g++.old-deja/g++.jason/scoping12.C (test for excess errors)
FAIL: g++.old-deja/g++.other/friend6.C (internal compiler error)
FAIL: g++.old-deja/g++.other/friend6.C (test for excess errors)
FAIL: g++.old-deja/g++.pt/friend11.C  (test for errors, line 12)
FAIL: g++.old-deja/g++.pt/friend11.C  (test for errors, line 24)
FAIL: g++.old-deja/g++.pt/friend11.C (internal compiler error)
FAIL: g++.old-deja/g++.pt/friend11.C (test for excess errors)
FAIL: g++.old-deja/g++.pt/friend12.C (internal compiler error)
FAIL: g++.old-deja/g++.pt/friend12.C (test for excess errors)
FAIL: g++.old-deja/g++.pt/friend13.C (internal compiler error)
FAIL: g++.old-deja/g++.pt/friend13.C (test for excess errors)

Does your new patch fix them?

Thanks.


-- 
H.J.