This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RFA: MN10300: Add definition of USER_LABEL_PREFIX
- From: Nick Clifton <nickc at redhat dot com>
- To: law at redhat dot com, aoliva at redhat dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 01 Oct 2009 09:49:58 +0100
- Subject: RFA: MN10300: Add definition of USER_LABEL_PREFIX
Hi Jeff, Hi Alex,
The MN10300 port uses an underscore prefix for user symbols but the
backend code is missing a definition of USER_LABEL_PREFIX. This is
causing some failures in the GCC and G++ testsuites:
FAIL: gcc.c-torture/execute/builtins/memops-asm.c compilation, -O0
FAIL: gcc.c-torture/execute/builtins/memops-asm.c compilation, -O1
FAIL: gcc.c-torture/execute/builtins/memops-asm.c compilation, -O2
FAIL: gcc.c-torture/execute/builtins/memops-asm.c compilation, -O3 -fomit-frame-pointer
FAIL: gcc.c-torture/execute/builtins/memops-asm.c compilation, -O3 -g
FAIL: gcc.c-torture/execute/builtins/memops-asm.c compilation, -Os
FAIL: gcc.c-torture/execute/builtins/strstr-asm.c compilation, -O0
FAIL: gcc.c-torture/execute/builtins/strstr-asm.c compilation, -O1
FAIL: gcc.c-torture/execute/builtins/strstr-asm.c compilation, -O2
FAIL: gcc.c-torture/execute/builtins/strstr-asm.c compilation, -O3 -fomit-frame-pointer
FAIL: gcc.c-torture/execute/builtins/strstr-asm.c compilation, -O3 -g
FAIL: gcc.c-torture/execute/builtins/strstr-asm.c compilation, -Os
FAIL: gcc.dg/alias-7.c (test for excess errors)
FAIL: gcc.dg/attr-alias-2.c (test for excess errors)
FAIL: g++.dg/rtti/repo1.C (test for excess errors)
FAIL: g++.dg/template/repo1.C (test for excess errors)
FAIL: g++.dg/template/repo3.C (test for excess errors)
FAIL: g++.dg/template/repo6.C (test for excess errors)
FAIL: g++.dg/template/repo8.C (test for excess errors)
FAIL: g++.dg/template/repo9.C (test for excess errors)
FAIL: g++.old-deja/g++.pt/instantiate4.C (test for excess errors)
FAIL: g++.old-deja/g++.pt/instantiate6.C (test for excess errors)
FAIL: g++.old-deja/g++.pt/repo1.C (test for excess errors)
FAIL: g++.old-deja/g++.pt/repo2.C (test for excess errors)
FAIL: g++.old-deja/g++.pt/repo3.C (test for excess errors)
FAIL: g++.old-deja/g++.pt/repo4.C (test for excess errors)
With the patch below applied all of these FAILs become PASSes and
there are no new failures introduced.
OK to apply ?
Cheers
Nick
gcc/ChangeLog
2009-10-01 Nick Clifton <nickc@redhat.com>
* config/mn10300/mn10300.h (USER_LABEL_PREFIX): Define.
Index: gcc/config/mn10300/mn10300.h
===================================================================
--- gcc/config/mn10300/mn10300.h (revision 152326)
+++ gcc/config/mn10300/mn10300.h (working copy)
@@ -759,6 +759,9 @@
#define ASM_APP_OFF "#NO_APP\n"
+#undef USER_LABEL_PREFIX
+#define USER_LABEL_PREFIX "_"
+
/* This says how to output the assembler to define a global
uninitialized but not common symbol.
Try to use asm_output_bss to implement this macro. */