This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Revert unintended changes
- From: Gabriel Dos Reis <gdr at cs dot tamu dot edu>
- To: gcc-patches at gcc dot gnu dot org
- Cc: jason at redhat dot com
- Date: Thu, 01 Oct 2009 02:12:05 -0500
- Subject: Revert unintended changes
Hi Jason,
When I committed the constexpr change, I used the wrong local tree
therefore end up committing changes that were not intended -- not
present in any of the versions you've seen and reviewed. The unwanted
commit changed some make_node() to cxx_make_type(). This patch reverts
that. I also took the opportunity to remove two obsolete ChangeLog
entries from that same commit.
OK?
*** gcc/cp/ChangeLog (revision 152388)
--- gcc/cp/ChangeLog (local)
***************
*** 1,9 ****
2009-09-30 Gabriel Dos Reis <gdr@cs.tamu.edu>
* decl.c (check_for_uninitialized_const_var): Check constexpr
variables too.
- (build_ptrmemfunc_type): Make the result a literal type.
- (build_ptrmem_type): Likewise.
(grokdeclarator): Handle `constexpr'.
(check_tag_decl): Reject `constexpr'.
(check_function_type): Check constexpr functions.
--- 1,12 ----
+ 2009-10-01 Gabriel Dos Reis <gdr@cs.tamu.edu>
+
+ * decl.c (record_builtin_java_type): Undo unintended change.
+ (cxx_init_decl_processing): Likewise.
+
2009-09-30 Gabriel Dos Reis <gdr@cs.tamu.edu>
* decl.c (check_for_uninitialized_const_var): Check constexpr
variables too.
(grokdeclarator): Handle `constexpr'.
(check_tag_decl): Reject `constexpr'.
(check_function_type): Check constexpr functions.
*** gcc/cp/decl.c (revision 152388)
--- gcc/cp/decl.c (local)
*************** record_builtin_java_type (const char* na
*** 3231,3237 ****
}
else
{ /* "__java_float" or ""__java_double". */
! type = cxx_make_type (REAL_TYPE);
TYPE_PRECISION (type) = - size;
layout_type (type);
}
--- 3231,3237 ----
}
else
{ /* "__java_float" or ""__java_double". */
! type = make_node (REAL_TYPE);
TYPE_PRECISION (type) = - size;
layout_type (type);
}
*************** cxx_init_decl_processing (void)
*** 3397,3403 ****
/* C++ extensions */
! unknown_type_node = cxx_make_type (UNKNOWN_TYPE);
record_unknown_type (unknown_type_node, "unknown type");
/* Indirecting an UNKNOWN_TYPE node yields an UNKNOWN_TYPE node. */
--- 3397,3403 ----
/* C++ extensions */
! unknown_type_node = make_node (UNKNOWN_TYPE);
record_unknown_type (unknown_type_node, "unknown type");
/* Indirecting an UNKNOWN_TYPE node yields an UNKNOWN_TYPE node. */
*************** cxx_init_decl_processing (void)
*** 3408,3420 ****
TYPE_POINTER_TO (unknown_type_node) = unknown_type_node;
TYPE_REFERENCE_TO (unknown_type_node) = unknown_type_node;
! init_list_type_node = cxx_make_type (UNKNOWN_TYPE);
record_unknown_type (init_list_type_node, "init list");
{
/* Make sure we get a unique function type, so we can give
its pointer type a name. (This wins for gdb.) */
! tree vfunc_type = cxx_make_type (FUNCTION_TYPE);
TREE_TYPE (vfunc_type) = integer_type_node;
TYPE_ARG_TYPES (vfunc_type) = NULL_TREE;
layout_type (vfunc_type);
--- 3408,3420 ----
TYPE_POINTER_TO (unknown_type_node) = unknown_type_node;
TYPE_REFERENCE_TO (unknown_type_node) = unknown_type_node;
! init_list_type_node = make_node (UNKNOWN_TYPE);
record_unknown_type (init_list_type_node, "init list");
{
/* Make sure we get a unique function type, so we can give
its pointer type a name. (This wins for gdb.) */
! tree vfunc_type = make_node (FUNCTION_TYPE);
TREE_TYPE (vfunc_type) = integer_type_node;
TYPE_ARG_TYPES (vfunc_type) = NULL_TREE;
layout_type (vfunc_type);
*************** cxx_init_decl_processing (void)
*** 3436,3442 ****
abi_node = current_namespace;
pop_namespace ();
! global_type_node = cxx_make_type (LANG_TYPE);
record_unknown_type (global_type_node, "global type");
/* Now, C++. */
--- 3436,3442 ----
abi_node = current_namespace;
pop_namespace ();
! global_type_node = make_node (LANG_TYPE);
record_unknown_type (global_type_node, "global type");
/* Now, C++. */