This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [libstdc++] decimal float support (take 2)
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: "janis187 at us dot ibm dot com" <janis187 at us dot ibm dot com>
- Cc: "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>, "bkoz at redhat dot com" <bkoz at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 1 Oct 2009 01:14:26 +0200
- Subject: Re: [libstdc++] decimal float support (take 2)
- References: <1254351606.6028.15.camel@janis-laptop>
Hi,
Tests are coming in a separate patch. I'd like to get this in for
4.5.
What changes are needed (with full testing) before it can go in as an
experimental feature?
First, thanks for this work. Since you are asking, I quickly went
through the code and the formatting seems rather off wrt the normal
conventions in the library, for example: no space between a function
name and the open round brace; no space between type and &; new line
before open curly brace, eg, for the body of a class definition,
likewise for a namespace; please have a look to the existing code for
guidance, we are rather consistent.
Thanks again,
Paolo