This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][libstdc++-v3 parallel mode] Uglification of internal identifiers


Paolo Carlini wrote:
> Hi,
>> Okay, so if nobody objects, I will commit the patch I have so far
>> (respecting recent other changes), then do some left-over detail
>> renamings, then convert the tabs to spaces and take case of the line breaks.
>>   
> first, thanks for this work. I don't know exactly which is the current
> status, just noticed that some names are still not uglified, is that
> being worked on? 

Yes.

> For example, BinaryFunction1, BinaryFunction2,
> traits_type1, traits_type2,
> traitsi_type, value_type1, value_type2, iteratorf_category,
> iterator1_traits, iterator2_traits, unary_op...

I have done another review, and uglified leftover identifiers, including
the above.  If you find some more, please tell me.

> parallel_unbalanced, sequential_tag, 
> count_minimal_n, default_parallel_tag, balanced_quicksort_tag,
> max_element_minimal_n, 

I would consider them part of the "interface".  Since they are likely to
be already used in user programs I would like to not change them.  They
are also unlikely to collide, because the names are very specific.

-- Johannes


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]