This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR target/41331 -- fix powerpc bswap64 with -m32 -mpowerpc64
On Thu, Sep 10, 2009 at 02:00:27PM -0400, David Edelsohn wrote:
> On Thu, Sep 10, 2009 at 12:39 PM, Michael Meissner
> <meissner@linux.vnet.ibm.com> wrote:
> > This patch should fix the problems that I introduced with my changes on July
> > 31st in __builtin_bswap64 if -m32 and -mpowerpc64 are used.
>
> Why should rs6000_emit_add() use the MODE of OP0 instead of
> TARGET_32BIT? gen_rtx_PLUS uses Pmode, which is based on
> TARGET_32BIT. Using TARGET_32BIT seems like a self-test that one does
> not pass an operand of the wrong MODE for an address.
In looking at it futher, I see optabs.c provides a gen_add3_insn function which
does the same thing that rs6000_emit_add did.
--
Michael Meissner, IBM
4 Technology Place Drive, MS 2203A, Westford, MA, 01886, USA
meissner@linux.vnet.ibm.com