This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: rs6000: Some fixes for bswapdi
On Wed, Sep 09, 2009 at 10:10:47AM -0400, David Edelsohn wrote:
> On Wed, Sep 9, 2009 at 3:28 AM, Segher
> Boessenkool<segher@kernel.crashing.org> wrote:
>
> >> I took your patches, and fixed some of the TARGET_POWERPC64 issues that I
> >> had
> >> in my original code. ?Assuming there are no additional regressions, is
> >> this ok
> >> to apply?
> >
> > I would prefer to keep the patches separate; mine is a bug fix, yours is
> > an essentially independent improvement.
>
> I agree with Segher. We have had too many problems recently caused by
> merging bugfixes and cleanups and improvements at the same time in the
> same patch.
>
> Is there any difference between Segher's patch and the version of his
> changes in your tree, Mike?
>
> Thanks, David
No. I did not modify any of Segher's changes. It looks fine. There is a bug
where bswapdi does not work with -m32 -mpowerpc64 that my changes addressed,
but I can certainly submit them after Segher applies his patch.
--
Michael Meissner, IBM
4 Technology Place Drive, MS 2203A, Westford, MA, 01886, USA
meissner@linux.vnet.ibm.com