This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch darwin] updated patch fixes PR41296, PR41245 (also re-enable checking removed in PR41224, PR41237)
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: IainS <developer at sandoe-acoustics dot co dot uk>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Mike Stump <mrs at apple dot com>
- Date: Wed, 09 Sep 2009 04:23:03 -0300
- Subject: Re: [patch darwin] updated patch fixes PR41296, PR41245 (also re-enable checking removed in PR41224, PR41237)
- References: <72F4A44E-A50D-4EE3-8DBE-0430DE0EB4F5@sandoe-acoustics.co.uk>
On Sep 8, 2009, IainS <developer@sandoe-acoustics.co.uk> wrote:
> Index: contrib/compare-debug
> ===================================================================
> --- contrib/compare-debug (revision 151491)
> +++ contrib/compare-debug (working copy)
> @@ -57,11 +57,20 @@
> trap 'rm -f "$1.$suf1" "$2.$suf2"' 0 1 2 15
> -cp "$1" "$1.$suf1"
> -strip "$1.$suf1"
> +sys=$(uname -s)
Please use `uname -s` instead of $(uname -s), for portability.
Also, please follow the indentation style of the script. Use two-blanks
indentation, and align case with the alternative, like this:
case `uname -s` in
Darwin)
ld -S ...
;;
*)
cp ...
;;
esac
Given a suitable ChangeLog entry and these changes, this is approved.
Thanks,
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist Red Hat Brazil Compiler Engineer