This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [VTA] retain more debug info in loop-ivopts
On Mon, Sep 7, 2009 at 8:00 AM, Alexandre Oliva<aoliva@redhat.com> wrote:
> On Sep ?5, 2009, Richard Guenther <richard.guenther@gmail.com> wrote:
>
>> Thus, can you at least change the patch so it stores SSA name versions in
>> the bitmap and move the topological walk and stmt remove to a helper
>> function (also getting rid of the weird remove_statement helper) in
>> tree-ssa.c (well, where you put the other debug stmt related helpers)?
>
> Good idea. ?Done.
>
>> + ? ? ? ? ? /* We can't propagate PHI nodes into debug stmts. ?*/
>> + ? ? ? ? ? if (gimple_code (stmt) == GIMPLE_PHI
>
>> that would mean we can remove PHI nodes immediately, no?
>
> Unfortunaly, no. ?If we remove them right away, other DEFs that refer to
> them may be propagated into debug stmts afterwards, and then the
> references to the dead SSA_NAMES that were defined in PHI nodes will
> remain. ?Kaboom. ?:-(
>
>> What is odd about remove_statement is the get_phi_with_result function.
>> It's obviously a no-op, the defining statement of the phi result is the phi
>> itself (it's so weird that I must miss something). ?Can you kill that while
>> you are around that corner?
>
> Done.
>
> This has completed bootstrap on i686-pc-linux-gnu, and test results look
> promising so far. ?Ok to install?
Ok.
Thanks,
Richard.
>
>
> --
> Alexandre Oliva, freedom fighter ? ?http://FSFLA.org/~lxoliva/
> You must be the change you wish to see in the world. -- Gandhi
> Be Free! -- http://FSFLA.org/ ? FSF Latin America board member
> Free Software Evangelist ? ? ?Red Hat Brazil Compiler Engineer
>
>