This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Ada] Add ??? comment in make.adb

From: Laurent GUERBY <laurent at guerby dot net>
To: Arnaud Charlet <charlet at adacore dot com>
Cc: gcc-patches at gcc dot gnu dot org, Robert Dewar <dewar at adacore dot com>
Date: Mon, 07 Sep 2009 09:52:29 +0200
Subject: Re: [Ada] Add ??? comment in make.adb
References: <20090817095952.GA18321@adacore.com> <1250805167.17842.28.camel@localhost>

On Thu, 2009-08-20 at 23:52 +0200, Laurent GUERBY wrote:
> I will submit a patch with a version of the above as comment in make.adb
> ASAP, sorry for not having done that in the first place.

Sorry for the delay, here is my documentation-only patch.

Laurent

2009-09-07  Laurent GUERBY  <laurent@guerby.net>

        * make.adb: Add missing documentation for multilib handling.

> On Mon, 2009-08-17 at 11:59 +0200, Arnaud Charlet wrote:
> > Laurent, your change in make.adb is missing several comments explaining
> > what the function does and how.
> > 
> > Also, your ChangeLog was not verbose enough (you didn't mention which
> > functions you changed for instance). You can still fix the ChangeLog
> > file now.
> > 
> > Thanks in advance for submitting a patch to address these issues.
> > 
> > Tested on x86_64-pc-linux-gnu, committed on trunk
> > 
> > 2009-08-17  Robert Dewar  <dewar@adacore.com>
> > 
> > 	* make.adb: Add ??? comment
> > 	Code clean up.
> >

Attachment: patch-ada-make-doc-multilib.txt
Description: Text document

Follow-Ups:
- Re: [Ada] Add ??? comment in make.adb
  - From: Arnaud Charlet

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]