This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] [Revised] libiberty hashtab.c:hash_pointer() needs intptr_t

From: Ozkan Sezer <sezeroz at gmail dot com>
To: Richard Henderson <rth at redhat dot com>
Cc: Richard Guenther <richard dot guenther at gmail dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>, Ian Lance Taylor <iant at google dot com>, gcc-patches at gcc dot gnu dot org, Kai Tietz <ktietz70 at googlemail dot com>
Date: Thu, 3 Sep 2009 23:26:39 +0300
Subject: Re: [PATCH] [Revised] libiberty hashtab.c:hash_pointer() needs intptr_t
References: <647fe9b10909030238q29cc9b81uf9cbdd6e2cc49e36@mail.gmail.com> <m3r5uogf9w.fsf@google.com> <6dc9ffc80909030947p4e8db854me0b157ed8177bb69@mail.gmail.com> <84fc9c000909030953w6628ecdei29cc0d9eec66b1f3@mail.gmail.com> <647fe9b10909031019h1cbfecb9s1d8837af894a3d15@mail.gmail.com> <4AA02099.6040903@redhat.com>

>>> AC_CHECK_TYPE(intptr_t, long)
>>>
>>> and this is wrong for LLP64 targets (likewise the existing uintptr_t
>>> check).
>>
>> The one LLP64 target that needs this patch is win64 and
>> it already has a proper stdint.h providing a correct (u)intptr_t.
>> In general, however, your are right about the incorrectness
>> of the long default type in AC_CHECK_TYPE, but the patch
>> just followed the existing uintptr_t check.
>
> I'll pre-approve a patch that changes these two AC_CHECK_TYPE
> instances to use the autoconf AC_TYPE_UINTPTR_T and
> AC_TYPE_INTPTR_T macros instead.
>
>
> r~
>

Like the attached (untested) patch?

Attachment: b2.diff
Description: Binary data

Follow-Ups:
- Re: [PATCH] [Revised] libiberty hashtab.c:hash_pointer() needs intptr_t
  - From: Richard Henderson

References:
- [PATCH] [Revised] libiberty hashtab.c:hash_pointer() needs intptr_t
  - From: Ozkan Sezer
- Re: [PATCH] [Revised] libiberty hashtab.c:hash_pointer() needs intptr_t
  - From: Ian Lance Taylor
- Re: [PATCH] [Revised] libiberty hashtab.c:hash_pointer() needs intptr_t
  - From: H.J. Lu
- Re: [PATCH] [Revised] libiberty hashtab.c:hash_pointer() needs intptr_t
  - From: Richard Guenther
- Re: [PATCH] [Revised] libiberty hashtab.c:hash_pointer() needs intptr_t
  - From: Ozkan Sezer
- Re: [PATCH] [Revised] libiberty hashtab.c:hash_pointer() needs intptr_t
  - From: Richard Henderson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]