This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: RFC libgomp/testsuite/libgomp.fortran
On Thu, Sep 03, 2009 at 12:49:46PM -0500, Loren James Rittle wrote:
>
> The only remaining concern are those four tests that I patched to add
> a port-selective -pthread have -fopenmp followed by -fno-openmp. Do
> those four cases need -lgomp to properly test some run-time aspects?
> I don't think so, but I don't really know fortran anymore.
>
When -fno-openmp is in effect, the four cases should not need -pthread.
The option -fopenmp essentially turns comment lines into executable
code. For example, with -fopenmp the following code:
troutmask:sgk[212] more condinc2.f
! { dg-options "-fno-openmp" }
program condinc2
logical l
l = .true.
C$ include 'condinc1.inc'
return
end
beomes
! { dg-options "-fno-openmp" }
program condinc2
logical l
l = .true.
return
end
which is perfectly fine Fortran and it does not require -pthread.
IMHO, the correct patch is the one to libgomp.exp. But, You'll probably
want to ping Jakub for his opinion.
--
Steve