This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: RFC libgomp/testsuite/libgomp.fortran
On Wed, Sep 02, 2009 at 04:31:33PM -0700, Steve Ellcey wrote:
> On Wed, 2009-09-02 at 16:18 -0700, Steve Kargl wrote:
>
> > As a gfortran maintainer and FreeBSD user, I've always considered these
> > failures to be bogus. The inclusion of -lgomp and -pthread are tied
> > to -fopenmp. If you look at the failures, you'll see an ordering of
> > '-fopenmp -O -fno-openmp', which correctly disables the inclusion
> > of -lgomp and -pthread. The only problem is that
> >
> > troutmask:sgk[251] find . -name \*.exp | xargs grep lgomp
> > ./lib/libgomp.exp: lappend ALWAYS_CFLAGS "ldflags=-lgomp"
> >
> > so dejagnu overrides -fno-openmp and adds -lgomp without adding
> > -pthread.
> >
> > Your changes look correct to me, but I can't approve patches
> > in the libgomp hierarchy.
>
> What would happen if we removed 'lappend ALWAYS_CFLAGS "ldflags=-lgomp"'
> from libgomp.exp? That seems like that would be the 'right' fix.
>
I don't know. Given that Jakub, Diego, and RTH wrote gomp,
I assume that they had a reason for this to be in libgomp.exp.
--
Steve