This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: stack-protector guard location
- From: Roland McGrath <roland at redhat dot com>
- To: Richard Henderson <rth at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 27 Aug 2009 17:12:51 -0700 (PDT)
- Subject: Re: stack-protector guard location
- References: <20090827225535.CF70E4050F@magilla.sf.frob.com> <4A971CE3.2060404@redhat.com>
> The following patch names this variable __stack_guard__ and injects
> it into the top-level scope of the function.
>
> Comments on the name or anything? Otherwise I'll commit this to
> mainline and 4.4 branch in 48 hours or so.
I was kind of thinking that "anonymous variable of type volatile pointer to
nothing" would be how we'd recognize it. Giving it this name does mean you
can suddenly make use of it without any new debugger support. But I'm not
so sure. I guess if it's DW_AT_artificial, the name means whatever we say
it means. But I don't think we want debuggers to think it's a
source-visible artifical variable (like "this" in C++ is).
I think I'd rather go with no name. Also, I think someone should try it
and verify whether the fake variable DIE confuses GDB at all before we
firmly decide what to emit.
Thanks,
Roland