Re: [Patch, Fortran] PR fortran/37425: Finish type-bound operators

[Daniel Kraft <d at domob dot eu>]

Tobias Burnus wrote:
> Daniel Kraft wrote:
> > Attached is the most recent version of my patch, now from my point of
> > view every issues are resolved.  Ok for trunk after a fresh
> > regression-test?
>
> typebound_operator_1.f90 has:
>
>    SUBROUTINE assign_proc (me, b)
>      CLASS(t), INTENT(OUT) :: me
>      LOGICAL, INTENT(IN) :: b
>      me = t ()
>    END SUBROUTINE assign_proc
>
> NAG f95 complains:
> ERROR: CLASS variable ME cannot be left-hand-side of intrinsic assignment
>
> I fully agree. How about adding a "logical" component and assigning the
> logcial component in assign_proc? For instance:
>      me%b = .not. b
> (The purpose of the .not. is to make it different from the intrinsic
> assignment :-)

I fixed this as suggested.

> Otherwise, the patch looks good can can be checked in.

Committed as rev. 151140.  I did a fresh bootstrap and regression test, 
and all but fmt_with_extra.f succeeded; that failure seems to have 
nothign to do with my patch, and Tobias agreed with me on IRC the patch 
can still go in.

Thanks for the review!  I'll now work on a documentation patch (internal 
doc, manual F2003 section and dump-parse-tree) as last piece and update 
the wiki.

> Please fill, if you didn't do yet, the PR about ELEMENTAL procedures.
> (Does this also affect PP(C)?) Ditto regarding the ambiguity check.

These are PR 41177 and PR 41178.

Cheers,
Daniel

--
Done:  Arc-Bar-Cav-Ran-Rog-Sam-Tou-Val-Wiz
To go: Hea-Kni-Mon-Pri