This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Ada] Add ??? comment in make.adb
- From: Laurent GUERBY <laurent at guerby dot net>
- To: Arnaud Charlet <charlet at adacore dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Robert Dewar <dewar at adacore dot com>
- Date: Thu, 20 Aug 2009 23:52:47 +0200
- Subject: Re: [Ada] Add ??? comment in make.adb
- References: <20090817095952.GA18321@adacore.com>
- Reply-to: laurent at guerby dot net
Hi,
The algorithm was described in my initial march 2009 email:
<<
Even if the Ada build process support multilib, gnatmake users currently
have to provide explicitely --RTS=xxx to select the right runtime, ie:
gnatmake $FLAGS --RTS=$(gcc -print-multi-directory $FLAGS)
The patch does special processing if and only if two conditions are
met:
1/ there is at least one -mxxx flag passed to gnatmake
2/ no --RTS is passed to gnatmake
If the two conditions are met then the GCC driver is called
with the collected -mxxx flags plus -print-multi-directory
and the resulting output is passed in a generated --RTS=
argument. Otherwise the patch does nothing and normal
gnatmake processing is done.
>>
I will submit a patch with a version of the above as comment in make.adb
ASAP, sorry for not having done that in the first place.
Sincerely,
Laurent
On Mon, 2009-08-17 at 11:59 +0200, Arnaud Charlet wrote:
> Laurent, your change in make.adb is missing several comments explaining
> what the function does and how.
>
> Also, your ChangeLog was not verbose enough (you didn't mention which
> functions you changed for instance). You can still fix the ChangeLog
> file now.
>
> Thanks in advance for submitting a patch to address these issues.
>
> Tested on x86_64-pc-linux-gnu, committed on trunk
>
> 2009-08-17 Robert Dewar <dewar@adacore.com>
>
> * make.adb: Add ??? comment
> Code clean up.
>