This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: implement fdiagnostics-print-source-range-info
2009/8/4 Tom Tromey <tromey@redhat.com>:
>>>>>> "Manuel" == Manuel López-Ibáñez <lopezibanez@gmail.com> writes:
>
> Manuel> ? ? ? ? * input.h (UNKNOWN_LOCATION_RANGE): Declare.
> Manuel> ? ? ? ? (location_t): Move typedef to line-map.h.
> Manuel> ? ? ? ? * toplev.c (UNKNOWN_LOCATION_RANGE): Define.
>
> Manuel> ? ? ? ? * include/line-map.h (location_t): Define here.
> Manuel> ? ? ? ? (struct location_range): New.
> Manuel> ? ? ? ? (location_range_t): New.
>
> Why put struct location_range and location_t in libcpp, but
> UNKNOWN_LOCATION_RANGE in gcc?
>
You are right. I think I'll move everything in toplev.c to line-map.
Anyway, it is not in libcpp, it is in line-map, which in turn is in
libcpp because we cannot be bothered to move it anywhere else.
> Aside from that the libcpp bits are fine by me.
Thanks!
Cheers,
Manuel.