This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Implement debug main pointer on IA64 VMS
- From: Jim Wilson <wilson at codesourcery dot com>
- To: Douglas B Rupp <rupp at gnat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, sje at cup dot hp dot com
- Date: Sun, 02 Aug 2009 10:48:10 -0700
- Subject: Re: [PATCH] Implement debug main pointer on IA64 VMS
- References: <4A712E96.9010200@gnat.com>
On Wed, 2009-07-29 at 22:24 -0700, Douglas B Rupp wrote:
> +#if VMS_DEBUGGING_INFO
> + if (vms_debug_main
> + && strncmp (vms_debug_main, fnname, strlen (vms_debug_main)) == 0)
> + {
> + targetm.asm_out.globalize_label (asm_out_file, VMS_DEBUG_MAIN_POINTER);
> + ASM_OUTPUT_DEF (asm_out_file, VMS_DEBUG_MAIN_POINTER, fnname);
> + dwarf2out_vms_debug_main_pointer ();
> + vms_debug_main = 0;
> + }
> +#endif
Shouldn't you check write_symbols here? There seems to be an assumption
here that if a target supports VMS debugging info, then it can't
possibly support any other type of debugging info. That may be true
currently, but still I think it is cleaner to check the current debug
info format.
You are calling the dwarf2out_vms_debug_main_pointer function, but I
didn't see that in your IA-64 patches. It could be in some separate
dwarf2 patch that wasn't cc'ed to me though.
Otherwise this looks OK to me. Steve Ellcey may have other comments.
Jim