Re: [PATCH][ARM] Add a missing fix in a previous patch for ICE 64-bit moves (rev 147612)

[Richard Earnshaw <rearnsha at arm dot com>]

On Fri, 2009-07-24 at 23:32 +0200, Mikael Pettersson wrote:
> =?Big5?B?RG91ZyBLd2FuICjD9q62vHcp?= writes:
>  > Hi,
>  > 
>  > This is a follow up of the following patch:
>  > 
>  > http://gcc.gnu.org/ml/gcc-patches/2009-05/msg00994.html
>  > 
>  > which fixes an ICE bug in adddi3.  A similar problem exists in subdi3
>  > but Richard's original patch does not fix that.  The patch below
>  > addresses the remaining issue.  it has been tested on
>  > arm-unknown-linux-gnueabi with no new regressions.
> 
> By visual inspection of the code there appears to be a similar problem
> in negdi2, see the patch below. Unfortunately my attempts to construct
> a test case triggering that pattern failed.
> 
> /Mikael
> 
> --- gcc-4.5-20090723/gcc/config/arm/arm.md.~1~	2009-07-23 17:02:20.000000000 +0200
> +++ gcc-4.5-20090723/gcc/config/arm/arm.md	2009-07-24 23:17:40.000000000 +0200
> @@ -3507,7 +3507,7 @@ (define_expand "negdi2"
>    if (TARGET_THUMB1)
>      {
>        if (GET_CODE (operands[1]) != REG)
> -        operands[1] = force_reg (SImode, operands[1]);
> +        operands[1] = force_reg (DImode, operands[1]);
>       }
>    "
>  )

Thanks, I've put this in.

In future, please remember to include a ChangeLog entry (but not in
patch form).

R.