This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] autopar - prepartion step for integration with Graphite
- From: Razya Ladelsky <RAZYA at il dot ibm dot com>
- To: Richard Guenther <richard dot guenther at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Zdenek Dvorak <rakdver at kam dot mff dot cuni dot cz>
- Date: Wed, 22 Jul 2009 15:56:34 +0300
- Subject: Re: [PATCH] autopar - prepartion step for integration with Graphite
Richard Guenther <richard.guenther@gmail.com> wrote on 22/07/2009
15:06:27:
> On Mon, Jul 20, 2009 at 12:58 PM, Razya Ladelsky<RAZYA@il.ibm.com>
wrote:
> > Hi,
> >
> > This patch is a preparation patch for the integration of autopar with
> > Graphite framework.
> > It is mainly reorganizing the code in a way that autopar's code
generation
> > could be called
> > even if the analysis wasn't, i.e. building up all needed information
> > independently of the analysis.
> > This will enable performing the dependency analysis in Graphite
framework,
> > and later calling
> > the code generation on the resulting parallel loops.
> > Another change is that canonicalize_loop_ivs was moved to
> > tree-ssa-loop-manip.c, so it can be
> > used externally (Graphite is using it as well).
> >
> > Bootstrap and regressions tests passed successfully (for
c,c++,fortran) on
> > linux powerpc.
> > Ok for mainline?
>
> +/* Data dependency analysis. Returns true if the iterations of LOOP
> + are independent on each other (that is, if we can execute them
> + in parallel).
> +*/
>
> the closing */ goes to the previous line.
>
> +static void
> +build_new_reduction (htab_t reduction_list, gimple reduc_stmt, gimple
phi)
> +{
> + PTR *slot;
> + struct reduction_info *new_reduction;
> +
> + gcc_assert (reduc_stmt);
> +
> + if (dump_file && (dump_flags & TDF_DETAILS))
> + {
> + fprintf (dump_file,
> + "Detected reduction. redu
>
> something is wrong with indent level here.
>
> Together with the comments from Li the patch is ok for trunk
> if Zdenek doesn't complain (I fixed the CC - it seems garbled).
>
Yes, I noticed that
I forwarded this patch to Zdenek yesterday,
Thanks for fixing it anyway,
Razya
> Thanks,
> Richard.