This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Fortran] RFC: Patch to support STDCALL etc. (PR 34112) * PING *
FX wrote:
> To fix this, I propose to add a function gfc_set_decl_assembler_name,
> which calls targetm.mangle_decl_assembler_name first and then uses
> SET_DECL_ASSEMBLER_NAME. All curent uses of SET_DECL_ASSEMBLER_NAME
> should probably be switched to gfc_set_decl_assembler_name().
I agree.
> The patch attached does what I describe above. I have been able to
> test that it does build for my cross-compiler (i386-darwin to
> i586-mingw32), gives object files with properly decorated function
> names and not warning at link time. The resulting executable (from
> Dennis' test) runs fine in a VirtualBox, and does not hit any abort. I
> am not able to bootstrap (nor regtest) a native compiler on a
> non-win32 platform, which should be tested before applying the patch.
> I don't expect any tricky issue though, as the only targets using the
> mangle_decl_assembler_name target hook are i386-winnt (cygwin and
> mingw) and i386-netware (don't know what that is).
I bootstrapped and regtested on x86-64-Linux; Dennis seemingly also did
some successful tests on i686-pc-cygwin. Thus: The patch is OK for the
trunk. (Will you check it in or do you prefer that someone else does it
for you due to time constraints?)
Tobias