This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] beat location sense into fold (PR/40435)
On Thu, Jul 16, 2009 at 5:50 PM, H.J. Lu<hjl.tools@gmail.com> wrote:
> On Thu, Jul 16, 2009 at 5:45 PM, H.J. Lu<hjl.tools@gmail.com> wrote:
>> On Thu, Jul 16, 2009 at 3:37 PM, Manuel
>> López-Ibáñez<lopezibanez@gmail.com> wrote:
>>> 2009/7/15 Aldy Hernandez <aldyh@redhat.com>:
>>>> On Wed, Jul 15, 2009 at 10:21:31AM -0700, Richard Henderson wrote:
>>>>> Ok.
>>>>
>>>> Manuel, thanks so much for taking care of this.
>>>>
>>>> Feel free to commit the patch, as you have the most recent version.
>>>
>>> Committed as rev 149722. Are you planning to work on something else
>>> about diagnostics?
>>>
>>
>> It caused:
>>
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40781
>>
>
> I am testing this patch. I will check it in if it fixes bootstrap.
>
>
> --
> H.J.
> Index: builtins.c
> ===================================================================
> --- builtins.c ?(revision 149726)
> +++ builtins.c ?(working copy)
> @@ -4168,7 +4168,9 @@ expand_builtin_memchr (tree exp, rtx tar
> ?static rtx
> ?expand_builtin_memcmp (tree exp, rtx target, enum machine_mode mode)
> ?{
> +#if defined HAVE_cmpmemsi || defined HAVE_cmpstrnsi
> ? location_t loc = EXPR_LOCATION (exp);
> +#endif
>
> ? if (!validate_arglist (exp,
> ? ? ? ? ? ? ? ? ? ? ? ? POINTER_TYPE, POINTER_TYPE, INTEGER_TYPE, VOID_TYPE))
> @@ -4433,7 +4435,9 @@ expand_builtin_strcmp (tree exp, rtx tar
> ?static rtx
> ?expand_builtin_strncmp (tree exp, rtx target, enum machine_mode mode)
> ?{
> +#ifdef HAVE_cmpstrnsi
> ? location_t loc = EXPR_LOCATION (exp);
> +#endif
>
> ? if (!validate_arglist (exp,
> ? ? ? ? ? ? ? ? ? ? ? ? POINTER_TYPE, POINTER_TYPE, INTEGER_TYPE, VOID_TYPE))
This one is better.
--
H.J.
Index: builtins.c
===================================================================
--- builtins.c (revision 149726)
+++ builtins.c (working copy)
@@ -4175,7 +4175,7 @@ expand_builtin_memcmp (tree exp, rtx tar
return NULL_RTX;
else
{
- tree result = fold_builtin_memcmp (EXPR_LOCATION (exp),
+ tree result = fold_builtin_memcmp (loc,
CALL_EXPR_ARG (exp, 0),
CALL_EXPR_ARG (exp, 1),
CALL_EXPR_ARG (exp, 2));
@@ -4440,7 +4440,7 @@ expand_builtin_strncmp (tree exp, rtx ta
return NULL_RTX;
else
{
- tree result = fold_builtin_strncmp (EXPR_LOCATION (exp),
+ tree result = fold_builtin_strncmp (loc,
CALL_EXPR_ARG (exp, 0),
CALL_EXPR_ARG (exp, 1),
CALL_EXPR_ARG (exp, 2));